search

lord-kyron / terraform-provider-phpipam

Terrform provider for PHPIPAM
https://registry.terraform.io/providers/lord-kyron/phpipam/latest
Apache License 2.0
54 stars 30 forks source link

Add section_id as optional parameter to firstfreesubnet Resource. #56

Closed steffencircle closed 1 year ago

steffencircle commented 1 year ago

Hi,

@pavel-z1 i decided to start with a new PR, since i messed up during the squashing.

As discussed earlier, this adds the section_id parameter to the firstfreeSubnet Resource and flags it as an Optional parameter to retain backwards-compatibility.

This fixes #53

I based it on-top of the current changes in the master branch and tested with those (provider sdk v2).

Can you please have a look ?

Steffen

steffencircle commented 1 year ago

Sorry for the mess.... will start again later...

steffencircle commented 1 year ago

I think it still looks good so @pavel-z1 can you please have a look ?

pavel-z1 commented 1 year ago

Looks good. Thank you @steffencircle

steffencircle commented 1 year ago

Hi @lord-kyron , @pavel-z1 ! do you plan the push a new release soon ?

Really hoping to get rid of my custom binaries !

Many thanks for for effort !