Using subnet in search of free ip

lord-kyron / terraform-provider-phpipam

Terrform provider for PHPIPAM

https://registry.terraform.io/providers/lord-kyron/phpipam/latest

Apache License 2.0

54 stars 30 forks source link

Using subnet in search of free ip #61

Closed tlitovsk closed 1 year ago

tlitovsk commented 1 year ago

Sometimes in the old DB of phpipam there are multiple subnets with the same IP ranges. I updated the phpipam-sdk-go with the ability to search with in subnet . The updated provider will use it when the subnet is specified. It is mostly for the first free resource which does not know how to handle identical IP results from multiple subnets.

tlitovsk commented 1 year ago

Hi . I did my best to try and make the test work; they were broken when I tried to run them on my machine Which maybe my machine's problem. I hope I did the proper fix.

lord-kyron commented 1 year ago

@pavel-z1 will you be able to review this, as I am planning to release new version which will include the update of the sdk from your repo and I want to include all the changes and pull requests which can be merged to this date! Thanks!

pavel-z1 commented 1 year ago

Hi @tlitovsk we want to create new release of phpipam provider Can you please finish this PR soon so that it is included in the new release?

Left to do:

update PR based on the latest master state
add to the README file usage case
remove changes from file go.mod https://github.com/lord-kyron/terraform-provider-phpipam/pull/61#discussion_r1176136253
rebase PR so that it includes only one commit, without a history of changes

tlitovsk commented 1 year ago

Readme updated. Rebased on updated master. go.mod removed . ( for some reason github closed and had to repoen the request) Commits squashed