lord-kyron / terraform-provider-phpipam

Terrform provider for PHPIPAM
https://registry.terraform.io/providers/lord-kyron/phpipam/latest
Apache License 2.0
54 stars 30 forks source link

Added l2domains controller. Fixed various bugs in another controllers #68

Closed pavel-z1 closed 1 year ago

pavel-z1 commented 1 year ago
pavel-z1 commented 1 year ago

Hi @lord-kyron This PR contains a large number of changes in the overlapping parts of the code. Therefore, to speed up the work, they were merged into one commit. First major implementation - added ability to manage l2fomains The second significant change is the refactoring of Unit tests and bringing them back to life.

There are also a number of smaller changes that affect bugs and fixes discovered after the restoration of Unit tests

This issue fixed here too.

pavel-z1 commented 1 year ago

Fix for issue added.

MatthieuuC commented 1 year ago

I've just tested it's not working, let me fix this before merge please :)

MatthieuuC commented 1 year ago

It's fixed in https://github.com/pavel-z1/phpipam-sdk-go/pull/15

pavel-z1 commented 1 year ago

Hi @MatthieuuC I propose to move this issue https://github.com/lord-kyron/terraform-provider-phpipam/issues/67 and discussion of its solution to the SDK project as reported issue not related to this project and PR.

pavel-z1 commented 1 year ago

@lord-kyron , I've recreated SDK release with tag v0.1.7 with included updated related to GET request No PR update needed here. We can merge PR