search

lord-kyron / terraform-provider-phpipam

Terrform provider for PHPIPAM
https://registry.terraform.io/providers/lord-kyron/phpipam/latest
Apache License 2.0
54 stars 30 forks source link

fix(request): don't add body on GET request #69

Closed MatthieuuC closed 1 year ago

MatthieuuC commented 1 year ago

Hello @lord-kyron,

I the latest release the fix provider in the SDK has no been applied.

Terraform logs (we can see the log for the empty body) :

2023-05-16T10:23:06.244+0200 [WARN]  unexpected data: registry.terraform.io/lord-kyron/phpipam:stderr="timestamp=2023-05-16T10:23:06.244486814+02:00 level=debug message="Request Body Debug ................... {}""
2023-05-16T10:23:06.244+0200 [WARN]  unexpected data: registry.terraform.io/lord-kyron/phpipam:stderr="timestamp=2023-05-16T10:23:06.24450661+02:00 level=debug message="Request URL Debug ...................Method: GET, UR: https://34.120.140.78/api/terraform/sections/""
2023-05-16T10:23:06.354+0200 [WARN]  unexpected data: registry.terraform.io/lord-kyron/phpipam:stderr="timestamp=2023-05-16T10:23:06.353915011+02:00 level=debug"
2023-05-16T10:23:06.354+0200 [WARN]  unexpected data: registry.terraform.io/lord-kyron/phpipam:stderr="message="Response Body Debug ................... \n<html><head>\n<meta http-equiv=\"content-type\" content=\"text/html;charset=utf-8\">\n<title>400 Bad Request</title>\n</head>\n<body text=#000000 bgcolor=#ffffff>\n<h1>Error: Bad Request</h1>\n<h2>Your client has issued a malformed or illegal request.</h2>\n<h2></h2>\n</body></html>\n""
2023-05-16T10:23:06.354+0200 [WARN]  unexpected data: registry.terraform.io/lord-kyron/phpipam:stderr=
2023-05-16T10:23:06.354+0200 [ERROR] provider.terraform-provider-phpipam_v1.5.0: Response contains error diagnostic: diagnostic_detail= diagnostic_summary="Non-API error (400 Bad Request): 
<html><head>

Thanks

lord-kyron commented 1 year ago

@pavel-z1 it seems we need to apply this again. Can you review it again?

lord-kyron commented 1 year ago

@pavel-z1 for some reason this change is not showing properly when I try to upgrade the vendor repo for the SDK. go.mod file says I am using SDK repo with that 0.1.7 but the file for the requests there is not changed.

lord-kyron commented 1 year ago

@MatthieuuC can you try ith version 1.5.2 now?