lorddusk / HQM

Hardcore Questing Mode
GNU Lesser General Public License v3.0
77 stars 61 forks source link

Break Block task doesn't work on many block types #449

Closed Funwayguy closed 5 years ago

Funwayguy commented 5 years ago

First noticed when block break tasks failed to detect any rail broken that wasn't in its default orientation (relevant if you want players to collection rails from mineshafts). This extends to many other kinds of blocks that have state dependent functionality and/or no 1-to-1 item block representation. Known affected blocks so far:

Note: I suspect the place block task may run into similar issues.

noobanidus commented 5 years ago

Progress so far:

Problem items:

noobanidus commented 5 years ago

All of the above work for block place tasks. I'll test the rest now.

noobanidus commented 5 years ago

Due to an issue with data corruption/server sync mode, coloured beds are not currently working properly. Following need to be dealt with for PLACE tasks only:

I have not begun testing any of these with break events.

As far as I know, everything above affects block place events as well, but I will be re-testing them.

noobanidus commented 5 years ago

Okay, signs, leaves and now flowerpots are stumping me again. I'll work on it more later.

noobanidus commented 5 years ago

Personal complaint (as this is what I): Faint Amaranth from Astral Sorcery.

noobanidus commented 5 years ago

So I just rewrote the whole thing as I'm done. The only actual override I had to make was for the flower pot. This is a much more reliable implementation, I feel like, although there will certainly be other mods which require custom mappings/functions to work properly...