lorddusk / HQM

Hardcore Questing Mode
GNU Lesser General Public License v3.0
77 stars 61 forks source link

Update item stack, compound tag, fluid stack and fraction serialization #655

Closed kirderf1 closed 2 years ago

kirderf1 commented 2 years ago

Fixes #654 and #649 (and related to #643) in 1.18. If the PR gets accepted, I assume that I'm fine to backport it to 1.16 without going through a PR. As this change changes the save format, it might make sense to let the next HQM version be 5.11.0. However this change is really only for code cleanup and fixing some issues, so it might not quite meet this standard. Should the next version be 5.10.1 then, rather than 5.11.0? When this gets backported to mc 1.16, it'd be HQM 5.5.17 as HQM 5.6.x is in mc 1.17.

canitzp commented 2 years ago

PR looks good. I can't validate if it works, but I assume you did. For the version, just use the lowest value, so 5.10.1 and yeah you can push the backportd directly