NullPointerException crash [1.19.2]

Rukia1727 commented 1 year ago

Crashes on 1.19.2 with the following error message The game crashed whilst exception in server tick loop Error: java.lang.NullPointerException: Exception in server tick loop

The crash log is as follows

`---- Minecraft Crash Report ---- // Daisy, daisy...

Time: 2023-10-29 11:41:13 Description: Exception in server tick loop

java.lang.NullPointerException: Exception in server tick loop at java.util.Objects.requireNonNull(Objects.java:209) ~[?:?] {re:mixin} at hardcorequesting.common.forge.io.adapter.QuestDataAdapter.deserialize(QuestDataAdapter.java:50) ~[HQM-1.19.2-5.13.1-forge.jar%23363!/:?] {re:classloading} at hardcorequesting.common.forge.io.adapter.TeamAdapter$1.deserialize(TeamAdapter.java:102) ~[HQM-1.19.2-5.13.1-forge.jar%23363!/:?] {re:classloading} at hardcorequesting.common.forge.io.adapter.TeamAdapter$1.deserialize(TeamAdapter.java:20) ~[HQM-1.19.2-5.13.1-forge.jar%23363!/:?] {re:classloading} at hardcorequesting.common.forge.io.adapter.Adapter.read(Adapter.java:28) ~[HQM-1.19.2-5.13.1-forge.jar%23363!/:?] {re:classloading} at com.google.gson.TypeAdapter.fromJsonTree(TypeAdapter.java:285) ~[gson-2.8.9.jar%23127!/:?] {} at hardcorequesting.common.forge.io.adapter.QuestingAdapter$1.deserialize(QuestingAdapter.java:55) ~[HQM-1.19.2-5.13.1-forge.jar%23363!/:?] {re:classloading} at hardcorequesting.common.forge.io.adapter.QuestingAdapter$1.deserialize(QuestingAdapter.java:18) ~[HQM-1.19.2-5.13.1-forge.jar%23363!/:?] {re:classloading} at hardcorequesting.common.forge.io.adapter.Adapter.read(Adapter.java:28) ~[HQM-1.19.2-5.13.1-forge.jar%23363!/:?] {re:classloading} at com.google.gson.internal.bind.TypeAdapterRuntimeTypeWrapper.read(TypeAdapterRuntimeTypeWrapper.java:41) ~[gson-2.8.9.jar%23127!/:?] {} at com.google.gson.internal.bind.CollectionTypeAdapterFactory$Adapter.read(CollectionTypeAdapterFactory.java:82) ~[gson-2.8.9.jar%23127!/:?] {} at com.google.gson.internal.bind.CollectionTypeAdapterFactory$Adapter.read(CollectionTypeAdapterFactory.java:61) ~[gson-2.8.9.jar%23127!/:?] {} at com.google.gson.Gson.fromJson(Gson.java:963) ~[gson-2.8.9.jar%23127!/:?] {re:mixin} at com.google.gson.Gson.fromJson(Gson.java:928) ~[gson-2.8.9.jar%23127!/:?] {re:mixin} at com.google.gson.Gson.fromJson(Gson.java:877) ~[gson-2.8.9.jar%23127!/:?] {re:mixin} at hardcorequesting.common.forge.io.SaveHandler.load(SaveHandler.java:71) ~[HQM-1.19.2-5.13.1-forge.jar%23363!/:?] {re:classloading} at hardcorequesting.common.forge.quests.QuestingDataManager$Data.loadFromString(QuestingDataManager.java:177) ~[HQM-1.19.2-5.13.1-forge.jar%23363!/:?] {re:classloading} at java.util.Optional.ifPresent(Optional.java:178) ~[?:?] {re:mixin} at hardcorequesting.common.forge.quests.SimpleSerializable.load(SimpleSerializable.java:21) ~[HQM-1.19.2-5.13.1-forge.jar%23363!/:?] {re:classloading} at hardcorequesting.common.forge.quests.QuestLine.loadAll(QuestLine.java:172) ~[HQM-1.19.2-5.13.1-forge.jar%23363!/:?] {re:classloading} at hardcorequesting.common.forge.event.WorldEventListener.onLoad(WorldEventListener.java:18) ~[HQM-1.19.2-5.13.1-forge.jar%23363!/:?] {re:classloading} at hardcorequesting.forge.HardcoreQuestingForge.lambda$registerOnWorldLoad$3(HardcoreQuestingForge.java:175) ~[HQM-1.19.2-5.13.1-forge.jar%23363!/:?] {re:classloading} at net.minecraftforge.eventbus.EventBus.doCastFilter(EventBus.java:260) ~[eventbus-6.0.3.jar%2385!/:?] {} at net.minecraftforge.eventbus.EventBus.lambda$addListener$11(EventBus.java:252) ~[eventbus-6.0.3.jar%2385!/:?] {} at net.minecraftforge.eventbus.EventBus.post(EventBus.java:315) ~[eventbus-6.0.3.jar%2385!/:?] {} at net.minecraftforge.eventbus.EventBus.post(EventBus.java:296) ~[eventbus-6.0.3.jar%2385!/:?] {} at net.minecraft.server.MinecraftServer.m129815(MinecraftServer.java:335) ~[client-1.19.2-20220805.130853-srg.jar%23463!/:?] {re:mixin,pl:accesstransformer:B,re:classloading,pl:accesstransformer:B,pl:mixin:A} at net.minecraft.server.MinecraftServer.m130006(MinecraftServer.java:300) ~[client-1.19.2-20220805.130853-srg.jar%23463!/:?] {re:mixin,pl:accesstransformer:B,re:classloading,pl:accesstransformer:B,pl:mixin:A} at net.minecraft.client.server.IntegratedServer.m7038(IntegratedServer.java:62) ~[client-1.19.2-20220805.130853-srg.jar%23463!/:?] {re:mixin,pl:runtimedistcleaner:A,re:classloading,pl:mixin:A,pl:runtimedistcleaner:A} at net.minecraft.server.MinecraftServer.m130011(MinecraftServer.java:625) ~[client-1.19.2-20220805.130853-srg.jar%23463!/:?] {re:mixin,pl:accesstransformer:B,re:classloading,pl:accesstransformer:B,pl:mixin:A} at net.minecraft.server.MinecraftServer.m206580(MinecraftServer.java:244) ~[client-1.19.2-20220805.130853-srg.jar%23463!/:?] {re:mixin,pl:accesstransformer:B,re:classloading,pl:accesstransformer:B,pl:mixin:A} at java.lang.Thread.run(Thread.java:833) [?:?] {re:mixin}

A detailed walkthrough of the error, its code path and all known details is as follows:

Rukia1727 commented 1 year ago

I get this crash often with hqm installed, if I uninstall hqm I do not see this error

kirderf1 commented 1 year ago

Looks like it might be the same issue as #684 which was fixed in HQM-1.19.4-5.14.1. The fix could be backported to the 1.19.2 version of the mod if desired.

kirderf1 commented 1 year ago

Having a closer look at it now, this crash happens during world load, wheras that other issue was happening on server -> client data sync, so the cause of this issue would be something else.

kirderf1 commented 1 year ago

Looks like this has to do with deleting a quest that a player has interacted with, causing a crash when the quest data for that player is loaded for a nonexistent quest. I assume that this issue applies to future HQM versions as well. I'll look into fixing the issue so that the quest data is discarded and a warning is logged instead of crashing the game.

lorddusk / HQM

NullPointerException crash [1.19.2] #686

A detailed walkthrough of the error, its code path and all known details is as follows: