lorddusk / HQM

Hardcore Questing Mode
GNU Lesser General Public License v3.0
78 stars 61 forks source link

[1.20.1][Feature Request] Fluids have fluid rendering instead of solid color #689

Open Epb7304 opened 9 months ago

Epb7304 commented 9 months ago

Issue: fluids are displaying solid color textures image

Change proposed: change back to old fluid rendering

OLD POST CONTENT:

This happens to modded fluids as well.

Specs: Minecraft version: 1.20.1 mod version: HQM-1.20.1-5.16.0-forge architectury version: architectury-9.1.12-forge forge version: NeoForge 47.1.100 operating system: Windows 10 Windows OS build: 19045.4046

no other mods were installed at the time, however, the issue persists with other mods installed.

Reproducibility: step 1: download mods and run Minecraft NeoForge using the specs given above. step 2: create a world, enable questing and editing, and give yourself a book step 3: create a set and quest, then attempt to change the icon of that quest to a fluid (not a bucket)

canitzp commented 9 months ago

Can you please tell me which items do use the barrier textures? I have tested a consume task, with fluids as source and yes there coloring is odd, but that is intentional. Therefor the water and lava (first 2 entries) of your quest are correct

Epb7304 commented 9 months ago

wait so the fluids are supposed to be solid colored textures? In jei it shows the correct textures

image image

in previous Minecraft modpacks that used an earlier version of this mod (Agrarian skies) it shows correctly

image image

also worth noting that a few mods that I also have installed add liquids themselves they all show various solid colors, and not the textures they should have, they also modify other fluid textures in the book, so water appears jet black image

canitzp commented 9 months ago

Yes the single color is currently intended. In a previous version, the fluid was rendered correctly, but one of the many mc/forge updated, changed the fluid rendering and to simplify the porting someone just used a single color for representation. This can be changed back to fluid rendering.

Epb7304 commented 9 months ago

Ah, I'm guessing that was probably around 1.13 since it had a lot of back-end changes. Well I'll edit the title to reflect that it is now a request

Epb7304 commented 9 months ago

by the way, this is what it looks like when you have ~10 mods that add various fluids. it becomes confusing very quickly image Description: from top left to bottom right

The latexs are different mods (thermal and industrial foregoing) The honey are different mods as well (cofh_core and productive bees)

This is without any mods that add a ton of liquids link tinkers