search

lorderic / android-training-project-4

Twitter App Client
0 stars 0 forks source link

[Android Bootcamp] Review my app #1

Open lorderic opened 9 years ago

lorderic commented 9 years ago

This is Eric Kuo. My project #4: Twitter app client is complete, please review. I have an issue on this project. Even I do reload my timeline after composing a new tweet, the new tweet does not show up right away. However it would show up after an immediate refresh. You can find out this issue on my video walkthrough. /cc @codepathreview @thecodepath @nidhi1608

nidhi1608 commented 9 years ago

client.composeTweet is an async call, so you may want to refresh timeline onSuccess of composeTweet. Let me know if that works.

lorderic commented 9 years ago

I've tried refreshing it within onSuccess of composeTweet but it still doesn't work. Instead I now inject the created tweet directly into the adapter for the timeline as mentioned in Helpful hints guide Note #1.

nidhi1608 commented 9 years ago

Great, I am glad you got it working.

nidhi1608 commented 9 years ago

:+1: Congrats on completing the assignment! Nice work overall. I have provided a detailed Feedback Guide here which covers the most common issues with this submitted project. Read through the feedback guide point-by-point to determine how you could improve your submission.

Let us know if you have any other thoughts or questions about this assignment. Hopefully by now you feel pretty comfortable with all the major pieces to basic Android apps (Views, Controllers, Models, Authentication, API Communication, Preferences, ActionBar, et al) and see how they all fit together.