search

lordfriend / nya-bootstrap-select

An AngularJS select replacement which build select like dropdown component with collection and ng-model support
http://nya.io/nya-bootstrap-select/
MIT License
179 stars 81 forks source link

Accessibility - Using keyboard letters to navigate through options #103

Open monkemedia opened 8 years ago

monkemedia commented 8 years ago

Please add if you think its worthwhile

     if(keyCode !== 27 && keyCode !== 13 && keyCode !== 38 && keyCode !== 40) {
        // My code
        var letter = String.fromCharCode(event.which);
        var filterLetter = $this.find('a:contains("'+ letter +'")').filter(function() {
          return $(this).text().indexOf(letter) === 0;
        });
        filterLetter.eq(0).focus();
      }
lordfriend commented 8 years ago

I think this is a useful feature and also be requested in #31 But I don't have a strong willing to implement this because new feature may introduce new bugs. So any one who can open a pull request is a great help.

monkemedia commented 8 years ago

Im sure I can do this for you. Do you have to give me permission for a pull request??

lordfriend commented 8 years ago

Any pull request conformed the contribute guide is welcomed. If you pull request pass the test, I'll merge the pull request

monkemedia commented 8 years ago

When I do a pull request I get this message:

Authentication Failed You may not have permission to access nya-bootstrap-select. Check Preferences to make sure you’re still logged in.

lordfriend commented 8 years ago

You should for this repository, commit your code into forked repository, then open a pull request on your repository, then I'll review your pull request and merge this pull request.