search

lordfriend / nya-bootstrap-select

An AngularJS select replacement which build select like dropdown component with collection and ng-model support
http://nya.io/nya-bootstrap-select/
MIT License
179 stars 81 forks source link

all tests failing, build is broken #121

Closed jpmckearin closed 8 years ago

jpmckearin commented 8 years ago

When attempting to build, all 13 tests fail with the following error:

Error: [$injector:modulerr] Failed to instantiate module ng due to: TypeError: 'undefined' is not an object (evaluating 'Function.prototype.bind.apply')

lordfriend commented 8 years ago

Building on travis-ci are all passed. Would you please try to reinstall the dependencies?

jpmckearin commented 8 years ago

The latest ci build was over a month ago. A current build is now failing (check out this pr - https://github.com/lordfriend/nya-bootstrap-select/pull/122). It looks like there's an issue with the dependencies. Since the error relates to instantiating ng module, possibly an issue with angular-mocks? I've been sifting through the angular issues/pr's trying to find something related.

jpmckearin commented 8 years ago

Looking at the builds, your last one was on Jan. 30. On Feb. 5, angular 1.5.0 was released.

jpmckearin commented 8 years ago

I have verified that resolving dependencies to angular 1.4.9 fixes the build, so there is a change in 1.5.0 that is causing the failure.

jpmckearin commented 8 years ago

Seems to be a compatability issue between angular 1.5.0 and PhantomJs 1.x. I will attempt to implement a fix and submit a pr.

https://github.com/angular/angular.js/issues/13794