search

lordi / tickmate

One bit journal
GNU General Public License v3.0
111 stars 33 forks source link

Fix issue #85 - weekday graph also shows percentage #146

Closed cipo7741 closed 3 years ago

cipo7741 commented 3 years ago

Hi lordi

I added the percentage above the numbers in the weekday chart. It is implemented checking the cyclic flag - thus another cyclic chart would also show percentages above. Had to split margin into marginTop and marginBottom. (Sorry about the whitespace changes.)

Hope you like it. 🛩️

Btw - awesome app ;-)

lordi commented 3 years ago

Awesome, Thanks! I'll review and merge it this weekend

cipo7741 commented 3 years ago

Hi Lordi,

I fixed another issue. Didn't know it would end up in the same merge - but here it is already. 🛸

So now people could add a SimpleDateFormat string in the Settings. For example dd-MM-yyyy It does also allow time and number of week which is of limited use.

Hope you like this as well.

lordi commented 3 years ago

Nice, I tested both changes and they work great.

Only one thing, maybe we can show a more descriptive subtitle here:

image

Something like "Override system date format (e.g. mm-DD-yyyy)" and remove the hint in the input box?

lordi commented 3 years ago

Because the hint does not show if the user entered "" as a dateformat. Entering an empty string as a date format should restore the original behaviour, this also does not seem to be the case rn

cipo7741 commented 3 years ago

sounds good

cipo7741 commented 3 years ago

Sorry - just saw that I commited with the wrong commit mail. I'll fix the commits later and make a new merge request. Not sure I can fix it right now (not used to rebases) - so maybe tomorrow.