search

lordmauve / adventurelib

A minimal library for writing text adventure games in Python 3
https://adventurelib.readthedocs.io/
MIT License
153 stars 42 forks source link

Replaces kwargs={} with **kwargs. #39

Closed flosincapite closed 3 years ago

flosincapite commented 3 years ago

Mutable objects as default arguments can produce subtle bugs. **kwargs is also more idiomatic.

lordmauve commented 3 years ago

I think replacing a dict argument with something non-mutable is fine, but changing to **kwargs creates the possibility of name collisions, and removes the possibility for future expansion. It isn't needed here.

flosincapite commented 3 years ago

Fair enough! I changed it to a default value of None.