search

lordmauve / pgzero

A zero-boilerplate games programming framework for Python 3, based on Pygame.
https://pygame-zero.readthedocs.io/
GNU Lesser General Public License v3.0
530 stars 190 forks source link

link on the tutorial web page is too new for the released version of pygame zero #192

Closed Naohiro2g closed 2 years ago

Naohiro2g commented 5 years ago

The tutorial document "Migrating from Scratch" https://pygame-zero.readthedocs.io/en/stable/from-scratch.html https://github.com/lordmauve/pgzero/commits/master/doc/from-scratch.rst

In this page there is a link to flappybird.py at github.com. It is linked to the examples/flappybird/flappybird.py in master branch. The linked code is too new for the latest released pygamezero 1.2 and causes name not defined error for 'storage' because storage.py had introduced after 1.2 release.

The link on the tutorial page should be linked to the 1.2release branch. https://github.com/lordmauve/pgzero/raw/1.2release/examples/flappybird/flappybird.py

jolly-jump commented 2 years ago

tried to fix it with #295 . Not 100% sure if the PR is against the correct branch though.

lordmauve commented 2 years ago

That fixes it, thanks!