search

lordmulder / LameXP

Audio Encoder Front-End
http://lordmulder.github.io/LameXP
Other
184 stars 18 forks source link

please make #14 an issue #58

Closed pupvogel closed 6 years ago

pupvogel commented 6 years ago

Hi, I just came across the behaviour that was reported in #14. This behaviour was really unexpected, because in my case, most subdirectories were included, but some were not - just because there was a file in the first level directory. Would be cool if there was a setting for this. Thanks !! 8o) Best Ken

lordmulder commented 6 years ago

Hello.

Since we already have a menu item to add a directory non-recursively and another distinct menu item to add a whole directory tree recursively, I think that additionally having an option that makes the "non-recursive" mode behave like the "recursive" one would not only be redundant but also kind of silly.

Furthermore, I think that having only one menu item for both, and instead using an option to switch between the "non-recursive" and the "recursive" mode would be less intuitive. And more annoying.

If people think that the current behavior of the "non-recursive" mode – will descend one level if and only if there are zero files on the current level – is too confusing, I'd rather remove that "feature".

Regards, MuldeR

pupvogel commented 6 years ago

Hi,

wow, how can a suggestion be silly that obviously intends to make your software more intuitive.

Out of the box, the program SEEMS to take in all the folders with subfolders that you drop on it. But it doesn't, it filters out SOME subfolders based on some weird check (that at least I and the author of #14 don't get). How could anyone expect this to happen before running into trouble..?

The extra menu-driven recursive mode (that I found after getting into that trouble) also forces me to create a special folder containing only the folders that I want to encode. That's not necessary when doing drag-and-drop.

Thank you for your kind consideration.

lordmulder commented 6 years ago

As said before, we already have distinct menu items to add a directory recursively or non-recursively. So you already can do both – without the need for another option. Adding an option that makes non-recursively mode behave like recursively mode would be "silly", because with such an option enabled, we then would have two menu items that do the exactly same thing – despite suggesting something else.

What seems to be the real point of confusion is that even the non-recursively mode – and Drag&Drop is nothing but a shortcut for that – will descend one level in the directory tree if and only if there are zero files in the selected directory. I thought that this "feature" would be a good idea – since the alternative would be adding no file at all in that particular case. But if this seemingly inconsistent behavior confuses many people, then I'd rather undo that "feature", instead of disimproving things with yet another option...

Regards, MuldeR

lordmulder commented 6 years ago

Fixed in 3bcf6a686aede183ec501da813e819d83cc9bf49.