search

lordmulder / LameXP

Audio Encoder Front-End
http://lordmulder.github.io/LameXP
Other
184 stars 18 forks source link

Plays sound although configured not to #86

Closed stonecrusher closed 4 years ago

stonecrusher commented 4 years ago

LameXP 4.17 Final-1 Build 2188 Win10x64 ver1909 Non-admin account

Reproduce:

  1. Tools -> Configuration -> check "Disable Sound Effects".
  2. Restart LameXP.
  3. Popup "Urgent Update" "Your version of LameXP is more than a year old. Time for an update!" -> choose "Ignore".
  4. Waiting music will play, but shouldn't.
lordmulder commented 4 years ago

Well, it should play 😈

We blatantly ignore the "Disable Sound Effects" setting here, because the update reminder is intended to be sort of "annoying", in order to give people some incentive to actually update their version...

But: Why the heck there is no update available now?

That is because I'm a bit late, this time around. So, seriously, shame on me for that! :cold_sweat:

(New version will hopefully be released soon™)

Regards.

stonecrusher commented 4 years ago

Well it was more of a jumpscare for me, but I got the message 😄 Oh and just a version bump without feature changes would do the trick!?

released soon™

Trademark registered by Berlin Airport GmbH 😏

BiatuAutMiahn commented 4 years ago

Or when your kid is asleep. I shouldn't have to mute the program through Window's sound mixer, or write my own implementation of this software in python to avoid dev that trolls his users lol.

imho, completely disabling the software as you once did if an update is available is more reasonable. Get rid of version expirations, some people don't have access to internet. If people don't update it's their fault, as a result they miss out on new features and/or bug fixes. The same thing tends to apply to pirates, if you pirate software don't expect help/support/updates/bug fixes.

isidroco commented 4 years ago

Music playing is totally unacceptable, I sometimes have recording sessions, and output is connected to high volume monitors. Opening lameXP would ruin that session and play a very loud sound. Popup is annoying but it won't ruin anything. PLEASE disable all sounds when that option is checked, (that should be default behaviour). If one checked: Don't check for updates, shouldn't it mean that? Sometimes I might want a particular old version, or simply don't want to test a new version until I'm ready: I don't update critical machines, sometimes it breaks things.

BiatuAutMiahn commented 4 years ago

I believe the older versions completely disable themselves

lordmulder commented 4 years ago

If one checked: Don't check for updates, shouldn't it mean that? Sometimes I might want a particular old version, or simply don't want to test a new version until I'm ready: I don't update critical machines, sometimes it breaks things.

The regular automatic (every 14 days) update check can be disabled.

The warning about using a deprecated program version can't be skipped, an that is for a reason :grimacing:

I believe the older versions completely disable themselves

Only pre-release TEST builds will expire after 31 days. Official releases never "disable themselves".

lordmulder commented 4 years ago

~blatantly ignore the "Disable Sound Effects" setting here, because the update reminder is intended to be sort of "annoying", in order to give people some incentive to actually update their version~

:point_right: 7179ad161ee9a9bc84cabbe02c7db1facc35dbf0