search

lordnull / dice.js

Generic RPG dice string parser and roller
MIT License
30 stars 3 forks source link

publish on npm? #10

Closed seiyria closed 9 years ago

seiyria commented 9 years ago

It'd be nice to have this available on npm as well, for use with a browserify environment or even just using it with node instead of in a browser.

lordnull commented 9 years ago

Before I publish on npm, I'd like someone to take a look at #11 to ensure it is sane.

seiyria commented 9 years ago

This seems ok to me (just having a cursory glance through it), but definitely it's a good idea to get another opinion.

lordnull commented 9 years ago

By merging in #11, still has been resolved!

Note that there has been a minor api change, instead of needing to dice.parse.parse and dice.eval.eval, you can just do dice.parse and dice.eval directly.

seiyria commented 9 years ago

Great. That's exciting! I'll give it a try today or tomorrow and get back to you.

seiyria commented 9 years ago

Yep! It worked perfectly as a drop-in solution. Thanks so much!