Open spmallette opened 10 years ago
Hi thank you so much for using this extension. There is an evolution of the library I am using which supports Java8 as well old versions https://github.com/rpau/javalang. I think it should be relatively easy to integrate it, I planned to integrate it in next month or so, but of course if you need it right now feel free to clone the project and integrate it and send a pull request.
Thank you so much for using it. Alex.
2014-05-18 22:17 GMT+02:00 stephen mallette notifications@github.com:
I'm not sure what's involved in getting Java 8 support besides bumping to the antlr version that supports it, but now that Java 8 is officially out there it would be nice to see java-semantic-asciidoctorj-extensionssupport it. Using it as-is (with support just for Java 7) on my Java 8 repo seems to work ok for my purposes, though I don't have wide usage yet.
I did try to bump the antlr versions myself and it seemed to work without too much effort, but I'm not sure if there was more involved than I'm realizing.
While the code changes are pretty small for the antlr bump, I think it could mean some bigger changes to the project structure if you wanted to support both java 7 and 8. Maybe the java 8 antlr stuff works backward against Java 7 and then there's no big deal, but i'm not sure on that either.
Anyway, since this could amount to a "big" change, I thought I'd try to get your thoughts before trying to change anything myself and issuing a pull request. Look forward to your feedback.
— Reply to this email directly or view it on GitHubhttps://github.com/lordofthejars/asciidoctorj-extensions/issues/2 .
+----------------------------------------------------------+ Alex Soto Bueno - Computer Engineer www.lordofthejars.com +----------------------------------------------------------+
Until it becomes a problem I'm not in a huge rush. Glad to hear this feature is on your radar. The main thing preventing me from going forward just this second is the dependency on SNAPSHOTs for this extension and asciidoctor-maven-plugin
. I imagine you would look to release something official once the asciidoctor-maven-plugin
is released from the 1.5.0.preview-testing
branch.
Anyway, I might have to be patient to use these features until those releases are official. At least its good to know that it all seems to work nicely together - that much made me feel pretty good.
I'm not sure what's involved in getting Java 8 support besides bumping to the antlr version that supports it, but now that Java 8 is officially out there it would be nice to see
java-semantic-asciidoctorj-extensions
support it. Using it as-is (with support just for Java 7) on my Java 8 repo seems to work ok for my purposes, though I don't have wide usage yet.I did try to bump the antlr versions myself and it seemed to work without too much effort, but I'm not sure if there was more involved than I'm realizing.
While the code changes are pretty small for the antlr bump, I think it could mean some bigger changes to the project structure if you wanted to support both java 7 and 8. Maybe the java 8 antlr stuff works backward against Java 7 and then there's no big deal, but i'm not sure on that either.
Anyway, since this could amount to a "big" change, I thought I'd try to get your thoughts before trying to change anything myself and issuing a pull request. Look forward to your feedback.