search

lordofthejars / diferencia

Tool to detect regressions between services
https://lordofthejars.github.io/diferencia-docs-site
Apache License 2.0
51 stars 7 forks source link

Does't working noisedetection #44

Open MrAndrejXz opened 5 years ago

MrAndrejXz commented 5 years ago

Hello! Diferencia run in a Docker container. I specify primary, secondary and candidate. I'm setting --noisedetection, but diferencia can't detect noise. My service returns the execution time of certain actions, so the time is always different.

lordofthejars commented 5 years ago

Hi, thanks for using it. I assume version 0.6.0. Can you try with http://worldclockapi.com/api/json/cet/now which is how I run the tests? Just to start checking if the problem might be in noise algorithm for your output or a generic problem.

MrAndrejXz commented 5 years ago

I use this docker-compose file: version: '2.1' services: diferencia: image: lordofthejars/diferencia:0.6.0 container_name: diferencia network_mode: host command: ["start", "-c", "http://worldclockapi.com/api/json/cet/now/", "-p", "http://worldclockapi.com/api/json/cet/now/", "-s", "http://worldclockapi.com/api/json/cet/now/", "-n", "--unsafe", "--headers"] image

lordofthejars commented 5 years ago

Ok the problem is in the headers not in the content, IIRC the noise detection thing only occurs in body content and not in headers. So I suggest using --ignoreHeadersValues=Date to avoid the comparision of the value of this header.

Missatge de MrAndrejXz notifications@github.com del dia dv., 5 de jul. 2019 a les 5:29:

I use this docker-compose file: version: '2.1' services: diferencia: image: lordofthejars/diferencia:0.6.0 container_name: diferencia network_mode: host command: ["start", "-c", "http://worldclockapi.com/api/json/cet/now/", "-p", "http://worldclockapi.com/api/json/cet/now/", "-s", " http://worldclockapi.com/api/json/cet/now/", "-n", "--unsafe", "--headers"] [image: image] https://user-images.githubusercontent.com/36975886/60696391-c3cf9d80-9f0f-11e9-88b7-1b1ecfcb72c5.png

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/lordofthejars/diferencia/issues/44?email_source=notifications&email_token=AALSMYIMS7SJFGDMQHOUGRTP525ZVA5CNFSM4H53U6T2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODZIOIPA#issuecomment-508617788, or mute the thread https://github.com/notifications/unsubscribe-auth/AALSMYK6Y6YRPKC57IAJAH3P525ZVANCNFSM4H53U6TQ .

-- +----------------------------------------------------------+ Alex Soto Bueno - Computer Engineer www.lordofthejars.com +----------------------------------------------------------+

MrAndrejXz commented 5 years ago

Does the definition of noise only work for the body?

lordofthejars commented 5 years ago

Yes in current version for this reason there is this exclude flag.

Missatge de MrAndrejXz notifications@github.com del dia dv., 5 de jul. 2019 a les 8:53:

Does the definition of noise only work for the body?

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/lordofthejars/diferencia/issues/44?email_source=notifications&email_token=AALSMYK6GFAZF36STMOPCDDP53VVRA5CNFSM4H53U6T2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODZIWQFA#issuecomment-508651540, or mute the thread https://github.com/notifications/unsubscribe-auth/AALSMYOW7TEF5LCSMHHLDRLP53VVRANCNFSM4H53U6TQ .

-- +----------------------------------------------------------+ Alex Soto Bueno - Computer Engineer www.lordofthejars.com +----------------------------------------------------------+

MrAndrejXz commented 5 years ago

Thanks for reply!