search

lordofthejars / quarkus-cheat-sheet

MIT License
35 stars 18 forks source link

Use Asciidoctor PDF (JS) as a dependency #24

Open ggrossetie opened 5 years ago

ggrossetie commented 5 years ago

This project was initiated as a fork of Asciidoctor PDF (JS) because (I believe that) at the time there was no release. Since then the project is now more stable and I think we should use Asciidoctor PDF as a dependency:

$ npm i -g asciidoctor asciidoctor-pdf

It would allow to remove a lot of code :boom:

lordofthejars commented 5 years ago

humm yes it might work, the good thing about how it is now it is that it is self-contained, on the other way you need to have everything installed to make it work. But yes maybe it could be a good next step.

ggrossetie commented 5 years ago

humm yes it might work, the good thing about how it is now it is that it is self-contained, on the other way you need to have everything installed to make it work.

Currently, you still need to run npm i to install the dependencies before you can use ./bin/asciidoctor-pdf.

But yes maybe it could be a good next step.

:+1: