search

loren138 / lk_cc

Constant Contact Plugin for ExpressionEngine
2 stars 2 forks source link

Syntax error prevents loading of pages containing the plugin tag #1

Closed elivz closed 11 years ago

elivz commented 11 years ago

You have a small but fatal error in the plugin file. On line 120, you have:

$_POST = ee()->security->xss_clean( $_POST );

which should be:

$_POST = $this->EE->security->xss_clean( $_POST );

This means any page containing the plugin shows only a blank screen with the PHP error. I changed it in my local copy and now it's working great!

loren138 commented 11 years ago

Fixed in 1.1.3. That is the only change in the release.

What version of EE are you running? I'm running 2.5.2 and it was working fine with the former version (ee()), but the latter is more correct so I'm happy to more the change.

elivz commented 11 years ago

I have 2.5.3 on this site. I don't see anything in the changelog that would indicate a change to this behavior... who knows?

Anyway, thanks for making the change. It's a very handy plugin, since Constant Contact makes it so difficult otherwise to create a simple newsletter signup form.

loren138 commented 11 years ago

Hm, We upgraded to 2.5.4 and the old version still worked for us. Could be a PHP version thing. Regardless, I'm going to close this. Thanks for your help.