search

lorensen / VTKExamples

The VTK examples, formerly hosted on media wiki
Apache License 2.0
344 stars 157 forks source link

Updating filenames cxx #574

Closed chakravarthi589 closed 5 years ago

chakravarthi589 commented 5 years ago

@ajpmaclean : I have added the example filenames that needs to passed as arguments. Is this fine to do like this where ever necessary in Cxx examples?

ajpmaclean commented 5 years ago

That's a really good idea. I have always mentioned the test files in the code, it gives the user something to try really quickly instead of hunting through the CMakeLists.txt file in the folder to find the parameters. I do a similar thing in Python. Generally if I convert an example to Python I'll update the C++ example, if it exists, at the same time. For Java and Python it is more important as there is no CMakeLists.txt file so the user needs hints as to what files to use, simple in Python because of argparse.

chakravarthi589 commented 5 years ago

Sure. I'll update C++ examples wherever appropriate. Thanks for your inputs.