lorensen / VTKExamples

The VTK examples, formerly hosted on media wiki
Apache License 2.0
344 stars 157 forks source link

Running CppCheck and modernising any of the changed Animation files #590

Closed ajpmaclean closed 5 years ago

lorensen commented 5 years ago

Andrew this is great. But I prefer the VTKSmartPointerFoo>::New() on a separate line. Fo me its helps scan the file.

ajpmaclean commented 5 years ago

I can't get this to work with the reformatting. Actually, I find it quite jarring to have just the auto xx = on the one line because you generally expect complete statements. But that is just my personal view.

Andrew Maclean

On Thu, 25 Jul 2019, 11:10 Bill Lorensen notifications@github.com wrote:

Andrew this is great. But I prefer the VTKSmartPointerFoo>::New() on a separate line. Fo me its helps scan the file.

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/lorensen/VTKExamples/pull/590?email_source=notifications&email_token=ACBHQO3JW7YFS4NRCY4O4BTQBD4PTA5CNFSM4IGVU6E2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD2YBBEY#issuecomment-514855059, or mute the thread https://github.com/notifications/unsubscribe-auth/ACBHQO4JZK3KU3JA5IXXJNTQBD4PTANCNFSM4IGVU6EQ .