search

lorensen / VTKExamples

The VTK examples, formerly hosted on media wiki
Apache License 2.0
344 stars 157 forks source link

Examples #614

Closed chethanab16 closed 5 years ago

chethanab16 commented 5 years ago

@lorensen @ajpmaclean Please review.

ajpmaclean commented 5 years ago

Some comments: 1) I suggest renaming src/Cxx/ImplicitFunctions/Quadric.cxx to src/Cxx/ImplicitFunctions/ImplicitQuadric.cxx - after all, it is demonstrating the creation of a quadric using implicit functions. 2) Sphere.cxx - It already exists as src/Cxx/GeometricObjects/Sphere.cxx, so your version needs to be renamed. However src/Cxx/ImplicitFunctions/ImplicitSphere.cxx also exists, so you should probably rename your version to src/Cxx/ImplicitFunctions/ImplicitSphere1.cxx. I think since your version adds in the contournig filter it is sufficiently different from the existing version. 3) Remember to update the markdown files and generate new test pngs.

chethanab16 commented 5 years ago

@ajpmaclean Please review, I made the required changes.

ajpmaclean commented 5 years ago

Thanks