Make y_obs optional for marginal_plot()

lorentzenchr / model-diagnostics

Tools for diagnostics and assessment of (machine learning) models

https://lorentzenchr.github.io/model-diagnostics/

MIT License

29 stars 4 forks source link

Make y_obs optional for marginal_plot() #178

Open samathizer opened 1 month ago

samathizer commented 1 month ago

There are use cases where we would like to inspect a model but we have no observed data at hand. For example if the model itself is a ensemble of models, the observed values are not easily available and we would still like to see the total effect of one feature in the form of the partial dependence plot as well as the average prediction per feature.

Proposition
Allow y_obs to be None. In that case only plot average of predicted as well as the histogram of the feature.

lorentzenchr commented 1 month ago

This feature sound reasonable to me. It would mean allowing for

plot_marginal(y_obs=None, ..)
compute_marginal(y_obs=None, ..)

PR welcome. I would recommend to start with the latter.