search

lorenzo / audit-stash

Flexible and rock solid audit log tracking for CakePHP 3
MIT License
78 stars 37 forks source link

Persist original values when record is deleted #50

Closed ishanvyas22 closed 4 years ago

ishanvyas22 commented 4 years ago

closes #19

codecov-commenter commented 4 years ago

Codecov Report

Merging #50 into 2.x will increase coverage by 0.23%. The diff coverage is 90.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##                2.x      #50      +/-   ##
============================================
+ Coverage     44.24%   44.47%   +0.23%     
+ Complexity      228      227       -1     
============================================
  Files            23       23              
  Lines           712      715       +3     
============================================
+ Hits            315      318       +3     
  Misses          397      397
Impacted Files Coverage Δ Complexity Δ
src/Persister/DatabasePersister.php 0.00% <0.00%> (ø) 6.00 <0.00> (-1.00)
src/Event/AuditDeleteEvent.php 100.00% <100.00%> (ø) 2.00 <1.00> (ø)
src/Model/Behavior/AuditLogBehavior.php 89.18% <100.00%> (+0.95%) 30.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 2a04617...d68c806. Read the comment docs.

ishanvyas22 commented 4 years ago

Ping @lorenzo

lorenzo commented 4 years ago

thanks!

bmudda commented 4 years ago

@lorenzo shouldn't this have been merged to 3.x branch? I am using version 3.0.1 and deleting an entity is not saving the original data. I am using AuditStash\Persister\TablePersister with MySQL as the storage.