search

lorenzo / audit-stash

Flexible and rock solid audit log tracking for CakePHP 3
MIT License
78 stars 37 forks source link

Resolves broken tests on local and adds GH actions pipeline #63

Closed cnizzardini closed 1 year ago

cnizzardini commented 1 year ago

This PR adds github actions pipeline so the library can be tested in all supported versions of CakePHP and PHP. It also resolves a number of errors, typos and inaccurate comments.

Resolves #62

Looking at the last PR some users @swiffer @gildonei and others may take issue with removing the mixed return type, but it seems as though that PR may have broken installs running 7.2 - 7.4.

If this PR is approved I suggest forcing PRs to pass checks, updating build image on readme, and ideally adding coveralls.io so we can see coverage statics.

cnizzardini commented 1 year ago

@lorenzo is this no longer maintained?

lorenzo commented 1 year ago

@cnizzardini not using this anymore, but I try to be a good open source citizen and merge things whenever I find the time. Thanks for your contribution!

lorenzo commented 1 year ago

@cnizzardini let me know if you would like to become a maintainer and I can give you commit bits

cnizzardini commented 1 year ago

Not sure I have the time or the deeper knowledge of all bits of this library to fully maintain it. I'd be fine maintaining it with a group of people though. Are there are any other contributors you can think of to add as well @lorenzo ?