search

lorenzodifuccia / safaribooks

Download and generate EPUB of your favorite books from O'Reilly Learning (aka Safari Books Online) library.
Do What The F*ck You Want To Public License
4.65k stars 691 forks source link

epub generated is partial #215

Closed vinayakg closed 1 year ago

vinayakg commented 4 years ago

I have tried the methods suggest in [Issue 150] (https://github.com/lorenzodifuccia/safaribooks/issues/150) and I am still getting complete book. I tried firefox and chrome, have also looked at the cookies one by one, but I still cant seem to get this to work. I have not seen the code yet, but if book is partially downloaded it cannot be a auth issue. Dont see any error when running the command image

Please help if any of you have already solved. Repro steps

lorenzodifuccia commented 4 years ago

Are you reading the EPUB with Apple iBook? Could you try to convert the EPUB to EPUB with Calibre? If you download Calibre, you will find also the command line ebook-converter tool, just run: ebook-converter <original_epub>.epub <clear_epub>.epub This will clean up the EPUB content and it will not fail to display as incomplete on ebook reader as iBook.

vinayakg commented 4 years ago

@lorenzodifuccia this solved the problem Got a bunch of CSS errors though, not sure if I need to worry about them

Ignoring CSS rule with invalid selector: u'input:read-only' (The pseudo-class :read-only is not supported)
Ignoring CSS rule with invalid selector: u'button::-moz-focus-inner' (The pseudo-class :-moz-focus-inner is not supported)
Ignoring CSS rule with invalid selector: u'.searchbox .search-query:focus::-webkit-input-placeholder' (The pseudo-class :-webkit-input-placeholder is not supported)
Ignoring CSS rule with invalid selector: u'.wrap-search-form .search-query:focus::-webkit-input-placeholder' (The pseudo-class :-webkit-input-placeholder is not supported)
Ignoring CSS rule with invalid selector: u'.searchbox select.search-params::-ms-expand' (The pseudo-class :-ms-expand is not supported)
Ignoring CSS rule with invalid selector: u'.wrap-search-form select.search-params::-ms-expand' (The pseudo-class :-ms-expand is not supported)
Ignoring CSS rule with invalid selector: u'.sbo-inpage-toc .tabs li::selection' (The pseudo-class :selection is not supported)
Ignoring CSS rule with invalid selector: u'#id_username:-moz-placeholder' (The pseudo-class :-moz-placeholder is not supported)
Ignoring CSS rule with invalid selector: u'#id_username:-ms-input-placeholder' (The pseudo-class :-ms-input-placeholder is not supported)
Ignoring CSS rule with invalid selector: u'#id_username::-webkit-input-placeholder' (The pseudo-class :-webkit-input-placeholder is not supported)
Ignoring CSS rule with invalid selector: u'#id_username::-moz-placeholder' (The pseudo-class :-moz-placeholder is not supported)
Ignoring CSS rule with invalid selector: u'input#id_username:-ms-input-placeholder' (The pseudo-class :-ms-input-placeholder is not supported)
Ignoring CSS rule with invalid selector: u'input#id_username::-moz-placeholder' (The pseudo-class :-moz-placeholder is not supported)
Ignoring CSS rule with invalid selector: u'input#id_username::-webkit-input-placeholder' (The pseudo-class :-webkit-input-placeholder is not supported)
Ignoring CSS rule with invalid selector: u'body.night-mode #sbo-rt-content .annotator-wrapper ::selection' (The pseudo-class :selection is not supported)
Ignoring CSS rule with invalid selector: u'body.night-mode #sbo-rt-content .annotator-wrapper ::-moz-selection' (The pseudo-class :-moz-selection is not supported)

Also images have been rescaled and my file size has become 50%. Do I need to worry about this and should I change any settings to maintain the same quality? Assuming lower images will show pixelated on larger screens. Also, Could you please explain how this solved the problem?

vinayakg commented 4 years ago

Also the original epub before conversion looks fine on epub-viewer from calibre

sesteva commented 3 years ago

I've pulled the latest code today and I'm also getting partial downloads. Each chapter only contains the very first page. Am I missing anything?

lorenzodifuccia commented 3 years ago

I've pulled the latest code today and I'm also getting partial downloads. Each chapter only contains the very first page. Am I missing anything?

Try: https://github.com/lorenzodifuccia/safaribooks/issues/215#issuecomment-631687918

sesteva commented 3 years ago

I figured it out. My bad. I had an old invalidated cookie.