Safarybooks.py not working anymore. Unhandled Exception: 'rights'

lorenzodifuccia / safaribooks

Download and generate EPUB of your favorite books from O'Reilly Learning (aka Safari Books Online) library.

Do What The F*ck You Want To Public License

4.62k stars 685 forks source link

Safarybooks.py not working anymore. Unhandled Exception: 'rights' #237

Closed tanvirrony closed 3 years ago

tanvirrony commented 3 years ago

Getting following error. [-] Logging into Safari Books Online... [-] Successfully authenticated. [*] Retrieving book info... [#] Unhandled Exception: 'rights' (type: KeyError) [!] Aborting...

jacabreragt commented 3 years ago

O'Reilly changed the API.

Here is the fix: https://github.com/jacabreragt/safaribooks/commit/250d1c611b970d53ce93ee6fe630cd582928370c

ashish2199 commented 3 years ago

@jacabreragt Can you please get this merged in this repo as well if it's working.

fyxtro commented 3 years ago

@ashish2199 if you make the same changes you see in the commit it works perfectly for now.

tanvirrony commented 3 years ago

Thanks @nhonaitran & @jacabreragt. After changing 177 & 964 line now its working fine.

TheDiegoFrade commented 3 years ago

Thanks! @nhonaitran @jacabreragt

lorenzodifuccia commented 3 years ago

Try to pull new commit (thanks to @nhonaitran with PR #239 and @avineshwar with PR #245)

Thank you @jacabreragt