search

lorenzodonini / ocpp-go

Open Charge Point Protocol implementation in Go
MIT License
275 stars 126 forks source link

ChargingProfileStatus NotImplemented should be NotSupported #161

Closed heavyweight87 closed 1 year ago

heavyweight87 commented 1 year ago

Hi,

We were sending status NotSupported and receiving an error. Turns out that it is incorrectly called NotImplemented: [here] https://github.com/lorenzodonini/ocpp-go/blob/956223d45e767a294840642385e48d298f925fd6/ocpp1.6/smartcharging/set_charging_profile.go#L20)

According to the 1.6 standard it should be NotSupported

Thanks

lorenzodonini commented 1 year ago

Nice catch, thanks!

Fixed it on master branch.