search

lorenzodonini / ocpp-go

Open Charge Point Protocol implementation in Go
MIT License
261 stars 125 forks source link

Allow ConfigurationKey values up to 1000 chars #258

Closed andig closed 6 months ago

andig commented 6 months ago

Fix https://github.com/evcc-io/evcc/issues/12901

Seems there are boxes sending >500 characters...

lorenzodonini commented 6 months ago

This does go against the spec (just to quote you on this topic https://github.com/lorenzodonini/ocpp-go/pull/240#issuecomment-1774188473). Then again this change would be harmless, until it remains constrained to configuration values, so that vendors can pass enormous JSON files in custom config 😅

To accept this, the unit test needs to be fixed accordingly though.

andig commented 6 months ago

Agreed regarding spec. Workaround is to not use getConfiguration in the case. Retracting, thank you!

premultiply commented 2 months ago

Workaround is to not use getConfiguration in the case.

That might be an expensive workaround. Even not usable in some cases.

I think it would be fine to accepting the double size of each value inside getConfiguration items for improved compatibility.