lorenzodonini / ocpp-go

Open Charge Point Protocol implementation in Go
MIT License
277 stars 126 forks source link

Added OCPP 1.6 security extension #265

Closed xBlaz3kx closed 8 months ago

xBlaz3kx commented 8 months ago

Proposed changes

Types of changes

What types of changes does your code introduce? Put an x in the boxes that apply

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

Further comments

dwibudut commented 8 months ago

Hi @xBlaz3kx,

Why not use the standard specification for ISO15118 in ocpp1.6, as described in the following document: https://openchargealliance.org/wp-content/uploads/2023/11/ocpp_1_6_ISO_15118_v10.pdf

xBlaz3kx commented 8 months ago

Hey @dwibudut,

this is the OCPP 1.6 security extension, which includes certificate management feature (TLS/SSL for websockets certificate management as well as ISO 15118 certificate management) among other features.

I'm not sure what you're trying to say - have I implemented something wrong in regards to certificate management?

dwibudut commented 8 months ago

Hi @xBlaz3kx,

There isn't anything wrong. Actually, I'm a little confused about whether the document (version via DataTransfer) is for features: for example CertificateSigned, GetInstalledCertificateIds in document above is no longer valid or only for PnC

xBlaz3kx commented 8 months ago

@dwibudut As I said before, this Security extension implementation has little to do with Plug and Charge feature implementation for OCPP 1.6. Here you can find any relevant information regarding this implementation.

Also, in the PnC specification, this note is applicable:

image

xBlaz3kx commented 8 months ago

Moving to #266