lorenzodonini / ocpp-go

Open Charge Point Protocol implementation in Go
MIT License
277 stars 126 forks source link

Feature(s): OCPP 1.6 configuration manager #286

Open xBlaz3kx opened 4 months ago

xBlaz3kx commented 4 months ago

Proposed changes

Implemented OCPP 1.6 configuration manager, based on my project. Features:

Types of changes

What types of changes does your code introduce? Put an x in the boxes that apply

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

andig commented 2 months ago

It isn't clear to me why this needs be part of this module. If it is for sake of integration capabilities it might be better to add the required APIs here and have the implementation in a separate repo.

xBlaz3kx commented 2 months ago

It isn't clear to me why this needs be part of this module. If it is for sake of integration capabilities it might be better to add the required APIs here and have the implementation in a separate repo.

Hey @andig,

afaik, it is a part of the roadmap for this repository and I think it would be nice to have everything ocpp related included in one repository.

The configuration manager also adds configuration key validation based on the OCPP profile(s), as each OCPP profile requires some configuration keys to be present (in OCPP specs), which would allow for more standardization and ease of use.