search

lorenzofox3 / Smart-Table

Code source of Smart Table module: a table/grid for Angularjs
http://lorenzofox3.github.io/smart-table-website/
1.8k stars 513 forks source link

Did you drop the support of bower in 2.1.9? #802

Closed Getz85 closed 6 years ago

Getz85 commented 6 years ago

AngularJS 1.6.6 SmartTable 2.1.9

My grunt build task doesn't inject the line <script src="bower_components/angular-smart-table/dist/smart-table.js"></script> in my html file as it did with the version 2.1.8.

After a quick look in the commit, it seems that you removed the bower.json file. I know bower is being deprecated, but if you really want to drop bower support, maybe you should release a major version instead of a bug fix, because it breaks an existing feature. In addition, the README is still indicating to install smart-table that

The easiest way is to run bower install angular-smart-table

foxdog05000 commented 6 years ago

I couldn't agree more!

RajShah94 commented 6 years ago

💯 spent all night yesterday trying to find what went wrong with bower!

ouranos commented 6 years ago

:100: Same here, our build is completely broken and it took me a while to figure out why smart-table was not picked up by wiredep...

BrunoChauvet commented 6 years ago

We had similar issue, wasting time to figure out what went out of whack

alexnoox commented 6 years ago

This is very confusing as the README still promote bower to install smart-table. Could we simply revert this file?

foxdog05000 commented 6 years ago

The Readme is not up to date! If in 2.1.9 you remove the Bower support! Remember to mention it prominently!

SimonLissack commented 6 years ago

This tripped me up as well, the quick fix (apart from downgrading) was to put this in overrides in bower.json:

    "angular-smart-table" : {
        "main": [
            "dist/smart-table.js"
        ]
    }

(You can also use dist/smart-table.min.js for the minified version)

foxdog05000 commented 6 years ago

It works very well, but it's like putting in a patch. The end of the Bower support must be provided correctly in a well-defined version. And mostly mentioned somewhere!

isaachinman commented 6 years ago

Also experienced a broken build. At 16k downloads per month you'd think the maintainers would understand semver.

lorenzofox3 commented 6 years ago

Sorry that was not on purpose (it is actually an older commit)

@isaachinman Instead of insulting OS maintainer who spend their free time on providing module you can use on your commercial projects you should thank them... and by the same occasion review your continuous deployment system because if a dependency issue makes your production go down, well I am not sure your product can be trusted !

SimonLissack commented 6 years ago

thanks @lorenzofox3 is deprecating bower support in the pipeline, should we prepare for it?