search

lorenzofox3 / Smart-Table

Code source of Smart Table module: a table/grid for Angularjs
http://lorenzofox3.github.io/smart-table-website/
1.8k stars 513 forks source link

aria-sort order is wrong #844

Open omkarbandkar opened 5 years ago

omkarbandkar commented 5 years ago

the aria-sort value is set to descending even when ascending sort is applied and vice-versa.

In file stSort.js on line number 90 .attr(ariaSort, newValue.reverse ? ariaSortAscending : ariaSortDescending); should be changed to .attr(ariaSort, newValue.reverse ? ariaSortDescending : ariaSortAscending );

since reverse indicated descending order, when reverse is true descending label should be shown