lorenzofox3 / smart-table-website

documentation website for smart table
18 stars 91 forks source link

Default bootstrap template for pagination has wrong mark-up #21

Closed blaise-io closed 9 years ago

blaise-io commented 9 years ago

The default pagination template is currently this:

<div class="pagination" ng-if="pages.length >= 2"><ul class="pagination">...</ul></div>

Due to ul.pagination being nested in div.pagination, there's double margins, which looks bad.

The default Bootstrap example uses this markup:

<nav ng-if="pages.length >= 2"><ul class="pagination">...</ul></nav>

I have overwritten the template in my own app, but I think it's good to fix the default in this library as well.

blaise-io commented 9 years ago

Wrong project…