lorenzofox3 / smart-table-website

documentation website for smart table
18 stars 91 forks source link

stSearch Documentation Correction #35

Closed kenhowardpdx closed 9 years ago

kenhowardpdx commented 9 years ago

In various places in the documentation it appears that the value of st-search is a string. But in reality it should be an expression that evaluates to a string.

I would update the documentation and submit a PR, but the documentation is missing.

Example:

Change this:
<input st-search="firstName" placeholder="search for firstname" class="input-sm form-control" type="search"/>

to this:
<input st-search="'firstName'" placeholder="search for firstname" class="input-sm form-control" type="search"/>

subtle change. Added single-quotes around the firstName key.

lorenzofox3 commented 9 years ago

I don't think it is true, what is the version you are using ? Refere to the change log (v2.0..0)

kenhowardpdx commented 9 years ago

@lorenzofox3 Good point. I'm using 1.4.13 :smile: Not going to upgrade though.