search

lorenzofox3 / smart-table-website

documentation website for smart table
18 stars 91 forks source link

Column Filtering #5

Closed chancyk closed 10 years ago

chancyk commented 10 years ago

There seems to be something missing with the filter section of the documentation. There's a directive defined in app.js that needed to be included in my code before the column filter would actually work. This isn't referenced in the documentation.

Am I correct about this? If so, I can submit a pull request to amend the documentation with that info.

lorenzofox3 commented 10 years ago

Hello,

Not really, actually this section shows how to use a custom cell template for a header. Then this custom directive is an example on how to use the controller api to filter by column only but this directive is not shipped with smart-table module. Of course you can add it to your application. Maybe the documentation could be clearer. Feel free to submit a pull request.

regards,

Laurent

chancyk commented 10 years ago

I've submitted a pull request that moves the customFilter directive code to be with the functional column filter demo. It also addresses a link coloring issue I noticed.