My only real point with that suggestion was you could get rid of the side-effects - there's no reason for createHarness to "clean up" or "undo" the effects of the global harness, if the global harness is opt-in rather than opt-out.
What I proposed would be a breaking change - zora would no longer export a createHarness, and the createHarness exported by zora/core wouldn't "undo" the global harness from zora, and hold wouldn't exist.
But as you said, there's no functional difference. I just like to simplify and make the internals a bit more explicit. If you don't think it's worth pursuing, you can just close the issue. 🙂
My only real point with that suggestion was you could get rid of the side-effects - there's no reason for
createHarnessto "clean up" or "undo" the effects of the global harness, if the global harness is opt-in rather than opt-out.What I proposed would be a breaking change -
zorawould no longer export acreateHarness, and thecreateHarnessexported byzora/corewouldn't "undo" the global harness fromzora, andholdwouldn't exist.But as you said, there's no functional difference. I just like to simplify and make the internals a bit more explicit. If you don't think it's worth pursuing, you can just close the issue. 🙂