search

lorenzoracca / Swift-binary-search

Binary search imply that will presented as proposal to swift-evolution
2 stars 2 forks source link

Revise 'impacts' section of proposal #10

Closed natecook1000 closed 8 years ago

natecook1000 commented 8 years ago

This clarifies the impact of the change and shows the relationship between the old and new partitioning methods. From my perspective, I think we're good to propose after this!

lorenzoracca commented 8 years ago

Thanks @natecook1000! Shouldn't we write the code for all of our APIs though? We just need one sortedRange and another one plus sortedIndexfor Comparable type. I am sorry but I couldn't write one.

natecook1000 commented 8 years ago

I'm not sure that the implementations need to be part of the proposal—the question for the list is "Are these the right APIs to add to the standard library?" If that answer is yes, then the implementation matters, but collections in general are in the middle of a big transition right now so it may be best to hold off. I have these all implemented in Swift 2.2—if you'd like I could build a Playground that we could link to so people could see/use the new APIs. Would that make sense?

lorenzoracca commented 8 years ago

Yes I agree. Okay then, it looks all fine to me and will present it if everyone agrees. Thanks