search

lorenzos / ZenCodingNetBeansPlugin

Zen Coding plugin for NetBeans
232 stars 57 forks source link

Fixed issue #16, issue #17 #18

Closed maxceem closed 11 years ago

maxceem commented 11 years ago

Fixed issue #16 so css abbreviations are expanded correctly in NetBeans 7.3 beta 2. The issue appeared because mime type spelling of css files (maybe others) was changed since 7.2 from 'text/x-css' to 'text/css' so default rules of html files were applied. My changes can be awkward and redundant but I tried to cover bacward compatibility and hypothetic forward compatibility.

Fixed issue #17 so abbreviations in .scss, .sass, .less files are expanded like in .css This issue is pretty close to previous one. I've tested with .scss and .less files as I didn't find a .sass support plugin. There can be a problem if other plugins define other mime types for the files from plugins I have used.

As I'm not a Java programmer and I don't know Netbeans plutform. So maybe you will rewrite the code in better way.

lorenzos commented 11 years ago

Code looks ok, there's no need to rewrite it. I only ask you: have you tested it personally with 7.3 or/and SASS/SCSS files?

maxceem commented 11 years ago

I've tested it in 7.3 beta 2 with .css, .scss, .less files as I haven't found a SASS support plugin.

But I want to note that the correct work of zendcode plugin depends on mime types which SCSS/SASS/LESS plugins define for their files. For example the LESS plugin I used defines mime type of less files as 'text/x-lesscss' which was quite unexpected.

So maybe the exact plugin names I've tested with should be noted: SCSS: http://plugins.netbeans.org/plugin/34929/scss-support LESS: http://plugins.netbeans.org/plugin/32782/lesscss-module

Or this functionality should be marked as 'test functionlaity' or something.

lorenzos commented 11 years ago

Ok, if you tested it against mime type of these popular plugins, it's enough. As you said, it depends on mime that depends on plugins. So, if somebody will report us another similar problem, we know we just have to inspect and add the new mime.

Merged. This afternoon I will pack it and release as 0.10 or 1.0 (I'm uncertain about it).