search

lorenzwalthert / precommit

pre-commit hooks for R projects
https://lorenzwalthert.github.io/precommit/
GNU General Public License v3.0
247 stars 48 forks source link

use {pak} to parallel install with {renv} #343

Open lorenzwalthert opened 2 years ago

lorenzwalthert commented 2 years ago

@pat-s offered to test with {mlr3viz}, which has a timeout because of dependency installation time > 120s. Potentially needs changes upstream in pre-commit.

pat-s commented 2 years ago

https://github.com/rstudio/renv/issues/459#issuecomment-989155616

lorenzwalthert commented 2 years ago

Not sure I want to opt-in into an experimental feature, in particular due to

Once we're more certain the integration is solid we'll consider turning this on by default.

Not sure what the ETA is for that. In any case, it's good to know that this is going to be the default at some point.

pat-s commented 2 years ago

We could test it in a precommit branch. I thought that eventually the effort will be small as its only an option you might need to set.

Not sure how easy it would to use a precommit branch though 🙂

lorenzwalthert commented 2 years ago

This affects the installation procedure of the hooks, which is not handled by {precommit} (or any repositories that implements hooks), but in the upstream framework, i.e. here. So testing this would involve a change in the upstream, a release in the upstream at least, as we don't control the version of pre-commit that is ran on pre-commit.ci

lorenzwalthert commented 2 years ago

Locally, we could test it before by installing a development version of pre-commit from a branch (note pre-commit=upstream, {precommit} = R package).