lorenzwalthert / precommit

pre-commit hooks for R projects
https://lorenzwalthert.github.io/precommit/
GNU General Public License v3.0
246 stars 46 forks source link

Failure with recently released pkgdown #576

Closed hadley closed 1 month ago

hadley commented 1 month ago

Now on CRAN:

 ── Error ('test-hook-pkgdown.R:2:1'): (code run outside of `test_that()`) ──────
    <purrr_error_indexed/rlang_error/error/condition>
    Error in `purrr::map2(path_candidate, path_candidate_temp, hook_state_assert_one,
        tempdir = tempdir, file_transformer = file_transformer, path_stdout = path_stdout,
        path_stderr = path_stderr, expect_success = expect_success,
        std_err = std_err, std_out = std_out, exit_status = exit_status)`: ℹ In index: 1.
    ℹ With name: man/autoudpate.Rd.
    Caused by error:
    ! Expected: No error. Found:
    Error in `check_pkgdown()`:
    ! In _pkgdown.yml, url is missing.
    ℹ See details in `vignette(pkgdown::metadata)`.
lorenzwalthert commented 1 month ago

Thanks, I saw that too. Will fix it.

lorenzwalthert commented 1 month ago

Closed with #582.