search

lorenzwalthert / touchstone

Smart benchmarking of pull requests with statistical confidence
https://lorenzwalthert.github.io/touchstone
Other
53 stars 7 forks source link

Emojis no longer rendered properly in the comments #126

Closed IndrajeetPatil closed 5 months ago

IndrajeetPatil commented 8 months ago

E.g. https://github.com/r-lib/styler/pull/1173#issuecomment-1890970457

Screenshot 2024-01-14 at 15 45 15
assignUser commented 8 months ago
assignUser commented 8 months ago

hm, maybe some changes to how automatic comments are treated?

assignUser commented 8 months ago

Editing around in another comment shows that they are rendered again when the leading html space is removed:

olivroy commented 5 months ago

Still an issue https://github.com/r-lib/styler/pull/1189#issuecomment-2025350896 and in comment above

Probably just needs as space to make it work ?

or maybe styler has not updated its workflows?

image

lorenzwalthert commented 5 months ago

Also don’t geht that. Styler seems to use the main tag, so it should use the latest commit on main: https://github.com/r-lib/styler/blob/208d9c7abb4eb44436695a68a19ea979c99ce921/.github/workflows/touchstone-comment.yaml#L20

However, I still see the ballot_box_with_check.. but the PR #127 changed that so I am confused. Do we need to release a new tag?

assignUser commented 5 months ago

In this repo the emojis show up fine: https://github.com/kgoldfeld/simstudy/pull/221#issuecomment-2016849698 So it seems to be a styler specific problem which I don't understand... actually simstudy uses an old version of the workflow where the /actions/receive is inlined. We need to update the v1 tag to point to HEAD of main.

assignUser commented 5 months ago

https://github.com/lorenzwalthert/touchstone/blob/main/actions/receive/action.yaml#L103

Sorry, I didn't think of that when we merged the fixes.

lorenzwalthert commented 5 months ago

Ok, so should we create a new tag and move the default? I guess no one would want to use @v1 anymore and there are no breaking changes. Should we release @v1.0.1 (as SemVer would suggest)? or what's the preferred versioning scheme with GitHub Actions?

assignUser commented 5 months ago

Usually for actions you would tag @v1.0.1 and additionally move the v1 tag to head

lorenzwalthert commented 5 months ago

Great. Can you do that?

assignUser commented 5 months ago

Done, that should propagate the fix to styler!

lorenzwalthert commented 5 months ago

It has, thanks a lot!