search

lorenzwalthert / touchstone

Smart benchmarking of pull requests with statistical confidence
https://lorenzwalthert.github.io/touchstone
Other
53 stars 7 forks source link

Fix the PR number artifact when triggered from a comment. #133

Closed plietar closed 4 months ago

plietar commented 4 months ago

The receive action was storing github.event.number as an artefact for the comment action to use. However, this field is only set for pull request events. If the workflow is configured to trigger on a comment, the event type is now issue_comment as the field is absent.

There is an equivalent field at github.event.issue.number, but that field is absent for PR events. The easiest way to get the number in a uniform and consistent way is to use the PR metadata we already have at the start of the action.

lorenzwalthert commented 4 months ago

Thanks. @assignUser do you agree? I lack the competence to approve this PR.

lorenzwalthert commented 4 months ago

Thanks to both.