search

lorenzwalthert / touchstone

Smart benchmarking of pull requests with statistical confidence
https://lorenzwalthert.github.io/touchstone
Other
53 stars 7 forks source link

Upload raw benchmark results as an artifact. #138

Closed plietar closed 3 months ago

plietar commented 3 months ago

The raw benchmark results weren't available anywhere. Exposing them as an artifact is convenient for investigation and to customize the rendering and visualization after the fact.

The receive action was uploading the PR comment as an artifact twice, once named "pr" and once named "results". Only the former is used by the comment action. Given the redundancy I assume this must have been a mistake. The "results" artifact now contains the raw benchmarking numbers instead.

I've also removed a spurious download-artifact step, which was downloading the same files that had just been uploaded, for no apparent reason.

plietar commented 3 months ago

Here is a test run using the PR: https://github.com/plietar/touchstone-test/actions/runs/9159004097/job/25178507557

lorenzwalthert commented 3 months ago

@plietar thanks for the suggestion. I don't have time for {touchstone} anymore, {precommit} and {styler} are already enough for me. Maybe @assignUser has / can? Sorry. I am also happy to transfer the repo to you or to #93. Would that be of interest to you? It would be great if the package can be further improved and I see you are eager to contribute 👍.