Open lorenzwalthert opened 3 years ago
@assignUser I suggest to pause the CRAN release process until you implemented more features.
@lorenzwalthert I think once #59 and #60 are merged we can continue with the cran release?
The problem is that I was using attach()
and the CRAN maintainers did not like it, although I followed best practices (see cran-comments.md
). We might have to export expr_eval()
to get through.
@lorenzwalthert what about withr::with_namespace?
Good idea! We'll have to try that I think...
I think we could proceed with CRAN submission now or do you have some other things you want to implement?
Well I have a list I once mentioned... Will try to put the items out as issues. Things on top of my mind:
benchmark_run_ref()
should probably be called benchmark_run()
only.run_script()
, within script, within benchmark_run_ref()
and how these relate to activate()
. I have some drawing I could digitize.What do you think about these things?
Ok sounds good. I think the time to hard-deprecate stuff is now, before anyone else uses the package :D I will think about/write up a draft for JOSS, I think being on cran would be good for that though, even if we then can include the citation only in the next cran version.
Was this abandoned due to difficulty with complying with CRAN? Would be great to have a release (and/or even a JOSS article).
I think it was more a case of other responsibilities taking over. I don't think the package has anything that would make a CRAN release especially difficult (e.g. no compiled code), so it's more a question of time/contributions.
Yes. If you want to submit to CRAN, and / or become maintainer, I am happy to transfer the GitHub repo over. I don’t have time to work on this package anymore. Sorry.
Prepare for release:
devtools::check_win_devel()
email.yml
thenrevdepcheck::revdep_email_maintainers()
Perform release:
devtools::submit_cran()
pkgdown::build_site()
Wait for CRAN...