lorenzwalthert / touchstone

Smart benchmarking of pull requests with statistical confidence
https://lorenzwalthert.github.io/touchstone
Other
53 stars 7 forks source link

cran release #31

Open lorenzwalthert opened 3 years ago

lorenzwalthert commented 3 years ago

Prepare for release:

Perform release:

Wait for CRAN...

lorenzwalthert commented 2 years ago

@assignUser I suggest to pause the CRAN release process until you implemented more features.

assignUser commented 2 years ago

@lorenzwalthert I think once #59 and #60 are merged we can continue with the cran release?

lorenzwalthert commented 2 years ago

The problem is that I was using attach() and the CRAN maintainers did not like it, although I followed best practices (see cran-comments.md). We might have to export expr_eval() to get through.

assignUser commented 2 years ago

@lorenzwalthert what about withr::with_namespace?

lorenzwalthert commented 2 years ago

Good idea! We'll have to try that I think...

assignUser commented 2 years ago

I think we could proceed with CRAN submission now or do you have some other things you want to implement?

lorenzwalthert commented 2 years ago

Well I have a list I once mentioned... Will try to put the items out as issues. Things on top of my mind:

What do you think about these things?

assignUser commented 2 years ago
lorenzwalthert commented 2 years ago
assignUser commented 2 years ago

Ok sounds good. I think the time to hard-deprecate stuff is now, before anyone else uses the package :D I will think about/write up a draft for JOSS, I think being on cran would be good for that though, even if we then can include the citation only in the next cran version.

sbfnk commented 6 months ago

Was this abandoned due to difficulty with complying with CRAN? Would be great to have a release (and/or even a JOSS article).

assignUser commented 6 months ago

I think it was more a case of other responsibilities taking over. I don't think the package has anything that would make a CRAN release especially difficult (e.g. no compiled code), so it's more a question of time/contributions.

lorenzwalthert commented 6 months ago

Yes. If you want to submit to CRAN, and / or become maintainer, I am happy to transfer the GitHub repo over. I don’t have time to work on this package anymore. Sorry.