search

loresoft / msbuildtasks

The MSBuild Community Tasks Project is an open source project for MSBuild tasks.
BSD 2-Clause "Simplified" License
946 stars 272 forks source link

Fix NUnit3 task on Linux #276

Open ermshiperete opened 6 years ago

ermshiperete commented 6 years ago

Current nunit3-console versions use "--" as switch separator on both Windows and Linux. Also the --verbose switch has been replaced by --trace=Verbose.

This change is Reviewable

ermshiperete commented 6 years ago

@JorisSpriet Good catch. What should happen if a user specifies both Verbose and InternalTrace?

JorisSpriet commented 6 years ago

I suggest to make Verbose take precedence. I entered some comment with the change too - these are my very first steps on GitHub...

In any case, the option is no longer supported in Nunit3 - so maybe also output a warning if it is used.

Joris.

On Tue, Jun 19, 2018 at 6:01 PM, Eberhard Beilharz <notifications@github.com

wrote:

@JorisSpriet https://github.com/JorisSpriet Good catch. What should happen if a user specifies both Verbose and InternalTrace?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/loresoft/msbuildtasks/pull/276#issuecomment-398453080, or mute the thread https://github.com/notifications/unsubscribe-auth/AJyu5-6O1qJVyBKRqvCX1cH_oHOlczDBks5t-SBXgaJpZM4SY0XY .