lorint / brick

Auto-generate models, views, controllers, and routes in a Rails app based on database structure
Other
286 stars 8 forks source link

possible bug? #4

Closed selamar closed 1 year ago

selamar commented 1 year ago

/usr/local/bundle/gems/brick-1.0.131/lib/brick/frameworks/rails/engine.rb:98: warning: found `= literal' in conditional, should be ==

lorint commented 1 year ago

warning: found `= literal' in conditional

Not a bug -- but also not elegant that it pops that warning!

Will update to use binding#local_variable_set in order to suppress this warning -- expect a release within 24 hours.

BTW -- thank you for testing Brick with .webp images!

lorint commented 1 year ago

Fixed in v1.0.132.

Thanks much for reaching out!

selamar commented 1 year ago

Alas, you make me waaay smarter than I am, I wasn't testing anything and I have no .webp images that I know of. The notice just popped out during the rails server bootstrap, I was looking because I'm trying to learn Rails. Anyway, great job!! Glad to be useful.

Sergio

Il giorno mer 19 apr 2023 alle ore 00:12 lorint @.***> ha scritto:

warning: found `= literal' in conditional

Not a bug -- but also not elegant that it pops that warning!

Will update to use binding#local_variable_set in order to suppress this warning -- expect a release within 24 hours.

BTW -- thank you for testing Brick with .webp images!

— Reply to this email directly, view it on GitHub https://github.com/lorint/brick/issues/4#issuecomment-1513853621, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABWDSTRDH5SRJECU4NB2EXDXB4GVNANCNFSM6AAAAAAXCYGLPU . You are receiving this because you authored the thread.Message ID: @.***>

lorint commented 1 year ago

The notice just popped out during the rails server bootstrap

Well then I'm thankful that you are keenly observant! Depending on what Ruby version you've got, some of those warnings do or don't appear, so this could be why I hadn't seen this yet.

The Rails community is a wonderful place and I hope you have fun with this great ecosystem!

selamar commented 1 year ago

Thanks, you too!

Il giorno mer 19 apr 2023 alle ore 13:05 lorint @.***> ha scritto:

The notice just popped out during the rails server bootstrap

Well then I'm thankful that you are keenly observant! Depending on what Ruby version you've got, some of those warnings do or don't appear, so this could be why I hadn't seen this yet.

The Rails community is a wonderful place and I hope you have fun with this great ecosystem!

— Reply to this email directly, view it on GitHub https://github.com/lorint/brick/issues/4#issuecomment-1514542696, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABWDSTT5AOZSR6ZC7GUO6E3XB7BF5ANCNFSM6AAAAAAXCYGLPU . You are receiving this because you authored the thread.Message ID: @.***>