search

loris-imageserver / loris

Loris IIIF Image Server
Other
209 stars 87 forks source link

Submitting GIF support changes #428

Open captmiddy opened 6 years ago

captmiddy commented 6 years ago

This is a pull request with GIF only changes. Once I hear back what types of tests would be expected, I will commit tests to the test folder for the GIF support.

arthurian commented 4 years ago

Hi all, I just wanted to add my voice in support of this PR. I would be interested in seeing this functionality merged, as we support GIF images for some users in our Loris installation.

In the past we've patched our install as this PR demonstrates, but it would be better to have it in the upstream repository and officially supported as an option. I'd be happy to help out with the requested changes if needed.

bcail commented 4 years ago

@arthurian great! @captmiddy can @arthurian help out with the requested changes? Or submit a new PR?

captmiddy commented 4 years ago

That would be great, I don't have time to work this right now with a bunch of other project work. We have been using this patch on our own version of Loris for a long time now but we have other local patches we have implemented that we should also look into.

arthurian commented 4 years ago

@captmiddy Just a heads up that I sent a PR to your branch with the requested changes (https://github.com/captmiddy/loris/pull/2).

captmiddy commented 4 years ago

I didn't rebase the webapp_t.py file before merging in this change. I honestly don't have time, but the changes that are off shouldn't be hard to merge. I don't have write to attempt a resolution anyway. The requested tests do appear to be in place now though.

bcail commented 4 years ago

@alexwlchan I got the test passing. You want to take a look and squash-merge if it looks OK?